[xa-prep-tasks] implemented GitCommitTime task #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonathanpeppers, |
jonpryor
reviewed
Aug 10, 2017
| WorkingDirectory="..\..\external\mxe" | ||
| /> | ||
| <GitCommitTime | ||
| WorkingDirectory="..\..\external\mxe" |
There was a problem hiding this comment.
Our indentation convention for XML is...different. :-)
Attributes should be one per line -- as you've done -- and attributes should be indented one "tab stop" (two spaces) further than nested elements. This is to make attributes and elements easier to distinguish visually:
<GitCommitTime
WorkingDirector="..\..\external\mxe"
ToolPath="$(GitToolPath)"
ToolExe="$(GitToolExe)">
<Output TaskParameter="Time" PropertyName="_MxeCommitTime" />
</GitCommitTime>Context: dotnet#181 (in comments) In several places throughout the build, we are running a command such as `<Exec Command="touch -m -t `git log -1 --format=%25cd --date=format-local:%25Y%25m%25d%25H%25M.%25S` Makefile" />`, which will not work on Windows. The solution is to create an MSBuild task in xa-prep-tasks named `GitCommitTime` that will work cross-platform. `GitCommitTime` returns a string value that can be passed to the `Touch` MSBuild task.
jonathanpeppers
force-pushed
the
git-commit-time
branch
from
8a729a3 to
0d7ff03
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #181 (in comments)
In several places throughout the build, we are running a command such
as the following, which will not work on Windows:
The solution is to create an MSBuild task in xa-prep-tasks named
GitCommitTimethat will work cross-platform.GitCommitTimereturnsa string value that can be passed to the
TouchMSBuild task.