Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[tests] update times in MSBuildDeviceIntegration.csv #7347

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

jonathanpeppers
Copy link
Member

Frequently 3 performance tests fail with times such as:

Build_CSharp_Change
Exceeded expected time of 3850ms, actual 3912.98ms
Build_AndroidManifest_Change
Exceeded expected time of 4250ms, actual 4873.595ms
Install_CSharp_Change
Exceeded expected time of 4500ms, actual 4693.08ms

Let's increase these times to make our CI runs less noisy.

At some point, we could also do some build performance work to get these times lower. Right now these time differences are pretty small, and I believe due to environmental changes in the CI machines, etc.

Frequently 3 performance tests fail with times such as:

    Build_CSharp_Change
    Exceeded expected time of 3850ms, actual 3912.98ms
    Build_AndroidManifest_Change
    Exceeded expected time of 4250ms, actual 4873.595ms
    Install_CSharp_Change
    Exceeded expected time of 4500ms, actual 4693.08ms

Let's increase these times to make our CI runs less noisy.

At some point, we could also do some build performance work to get
these times lower. Right now these time differences are pretty small,
and I believe due to environmental changes in the CI machines, etc.
@jonpryor jonpryor merged commit 63b3e0e into dotnet:main Sep 7, 2022
@jonathanpeppers jonathanpeppers deleted the test-times- branch September 7, 2022 18:58
grendello added a commit to grendello/xamarin-android that referenced this pull request Sep 8, 2022
* main:
  [tests] update times in MSBuildDeviceIntegration.csv (dotnet#7347)
  [.vscode] use net7.0-android (dotnet#7268)
jonathanpeppers added a commit that referenced this pull request Sep 14, 2022
Frequently these three performance tests fail with times such as:

  * Build_CSharp_Change

        Exceeded expected time of 3850ms, actual 3912.98ms

  * Build_AndroidManifest_Change

        Exceeded expected time of 4250ms, actual 4873.595ms

  * Install_CSharp_Change

        Exceeded expected time of 4500ms, actual 4693.08ms

Let's increase these times to make our CI runs less noisy.

At some point, we could also do some build performance work to get
these times lower. Right now these time differences are pretty small,
and I believe due to environmental changes in the CI machines, etc.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants