[One .NET] error with XA1030 for AOT and PublishTrimmed=false #7406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#7178 Using this combination: <PropertyGroup Condition=" '$(Configuration)' == 'Release' "> <RunAOTCompilation>true</RunAOTCompilation> <PublishTrimmed>false</PublishTrimmed> </PropertyGroup> Causes apps to crash at runtime with: 07-18 11:39:53.613 20269 20269 D Mono : AOT: module Microsoft.Maui.dll.so is unusable (GUID of dependent assembly Xamarin.AndroidX.AppCompat doesn't match (expected '1FC81757-8A70-4D56-93E6-8A635E2C23DE', got 'FD3821D1-CBF4-4956-B930-EA2A5379E18D')). AOT runs right after the `<ILLink/>` MSBuild task, and so the combination currently doesn't work when trimming is disabled. For now, to solve this let's emit a `XA1030` error and fail the build. This way you at least get a reasonable error at build time instead of at runtime. I do not know of a scenario when it would be useful to disable trimming completely during a `Release` + AOT build. If you are hitting a trimming/linker issue, you would be better off preserving a single assembly, type, etc.
jonathanpeppers
requested review from
dellis1972 and
jonpryor
as code owners
dellis1972
approved these changes
Sep 27, 2022
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Sep 27, 2022
* main: [Xamarin.Android.Build.Tasks] XA1030 for AOT + PublishTrimmed=false (dotnet#7406)
jonathanpeppers
added a commit
that referenced
this pull request
Sep 27, 2022
…7406) Fixes: #7178 Using this combination on .NET 6+: <PropertyGroup Condition=" '$(Configuration)' == 'Release' "> <RunAOTCompilation>true</RunAOTCompilation> <PublishTrimmed>false</PublishTrimmed> </PropertyGroup> Causes apps to crash at runtime with: D Mono : AOT: module Microsoft.Maui.dll.so is unusable (GUID of dependent assembly Xamarin.AndroidX.AppCompat doesn't match (expected '1FC81757-8A70-4D56-93E6-8A635E2C23DE', got 'FD3821D1-CBF4-4956-B930-EA2A5379E18D')). AOT runs right after the `<ILLink/>` MSBuild task, and so this combination currently doesn't work when trimming is disabled. For now, solve this by emitting an `XA1030` error and fail the build. This way you at least get a reasonable error at build time instead of at runtime. I do not know of a scenario when it would be useful to disable trimming completely during a `Release` + AOT build. If you are hitting a trimming/linker issue, you would be better off preserving a single assembly, type, etc.
jonathanpeppers
added a commit
that referenced
this pull request
Sep 27, 2022
…7406) Fixes: #7178 Using this combination on .NET 6+: <PropertyGroup Condition=" '$(Configuration)' == 'Release' "> <RunAOTCompilation>true</RunAOTCompilation> <PublishTrimmed>false</PublishTrimmed> </PropertyGroup> Causes apps to crash at runtime with: D Mono : AOT: module Microsoft.Maui.dll.so is unusable (GUID of dependent assembly Xamarin.AndroidX.AppCompat doesn't match (expected '1FC81757-8A70-4D56-93E6-8A635E2C23DE', got 'FD3821D1-CBF4-4956-B930-EA2A5379E18D')). AOT runs right after the `<ILLink/>` MSBuild task, and so this combination currently doesn't work when trimming is disabled. For now, solve this by emitting an `XA1030` error and fail the build. This way you at least get a reasonable error at build time instead of at runtime. I do not know of a scenario when it would be useful to disable trimming completely during a `Release` + AOT build. If you are hitting a trimming/linker issue, you would be better off preserving a single assembly, type, etc.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7178
Using this combination:
Causes apps to crash at runtime with:
AOT runs right after the
<ILLink/>MSBuild task, and so the combination currently doesn't work when trimming is disabled.For now, to solve this let's emit a
XA1030error and fail the build. This way you at least get a reasonable error at build time instead of at runtime.I do not know of a scenario when it would be useful to disable trimming completely during a
Release+ AOT build. If you are hitting a trimming/linker issue, you would be better off preserving a single assembly, type, etc.