Use Environment.SpecialFolder.UserProfile, not SpecialFolder.Personal #7481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/runtime#68610 In .NET 8, a test using `SpecialFolder.Personal` failed with: [FAIL] Create table attempt failed! SQLite.SQLiteException: Could not open database file: /data/user/0/com.xamarin.customlinkdescriptionpreserve/files/Documents/TaskDB.db3 (CannotOpen) at SQLite.SQLiteConnection..ctor(SQLiteConnectionString ) at SQLite.SQLiteConnectionWithLock..ctor(SQLiteConnectionString ) at SQLite.SQLiteConnectionPool.Entry..ctor(SQLiteConnectionString ) at SQLite.SQLiteConnectionPool.GetConnectionAndTransactionLock(SQLiteConnectionString , Object& ) at SQLite.SQLiteConnectionPool.GetConnection(SQLiteConnectionString ) at SQLite.SQLiteAsyncConnection.GetConnection() at SQLite.SQLiteAsyncConnection.<>c__DisplayClass33_0`1[[SQLite.CreateTableResult, SQLite-net, Version=1.7.335.0, Culture=neutral, PublicKeyToken=null]].<WriteAsync>b__0() at System.Threading.Tasks.Task`1[[SQLite.CreateTableResult, SQLite-net, Version=1.7.335.0, Culture=neutral, PublicKeyToken=null]].InnerInvoke() at System.Threading.Tasks.Task.<>c.<.cctor>b__273_0(Object ) at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread , ExecutionContext , ContextCallback , Object ) --- End of stack trace from previous location --- at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread , ExecutionContext , ContextCallback , Object ) at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& , Thread ) --- End of stack trace from previous location --- at LinkTestLib.Bug35195.AttemptCreateTable() All regression tests completed. In .NET 8+, we should use `SpecialFolder.UserProfile` instead.
|
Related: dotnet/android-tools@0be567a |
|
One classic test failed on provisionator, but we can probably ignore? |
dellis1972
approved these changes
Oct 24, 2022
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 26, 2022
* main: Use Environment.SpecialFolder.UserProfile, not SpecialFolder.Personal (dotnet#7481) [dependabot] Fix automatic submodule updates (dotnet#7482)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 26, 2022
* main: Use Environment.SpecialFolder.UserProfile, not SpecialFolder.Personal (dotnet#7481) [dependabot] Fix automatic submodule updates (dotnet#7482)
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/runtime#68610
In .NET 8, a test using
SpecialFolder.Personalfailed with:In .NET 8+, we should use
SpecialFolder.UserProfileinstead.