-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Tests] Replace azurestorage with a github repo. #7524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `https://xamjenkinsartifact.azureedge.net` site for some of the unit test data seems to have disappeared. So lets use a github repo to store this data instead. The unit tests can download the raw files directly from github. The repo will be public as well so there won't be any need for authorization.
jonathanpeppers
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good if the tests pass.
This is still in progress so don't merge yet |
I reran some test lanes that timed out. The tests like these should hopefully be fixed by #7505: |
I'm merging this, as it gets things much greener than they were. 💚 |
jonathanpeppers
pushed a commit
that referenced
this pull request
Nov 3, 2022
Our `https://xamjenkinsartifact.azureedge.net` site for some of the unit test data seems to have disappeared. So lets use a github repo to store this data instead. The unit tests can download the raw files directly from github. The repo will be public as well so there won't be any need for authorization. Update `DeleteBinObjTest` to use `7z`
jonathanpeppers
pushed a commit
that referenced
this pull request
Nov 3, 2022
Our `https://xamjenkinsartifact.azureedge.net` site for some of the unit test data seems to have disappeared. So lets use a github repo to store this data instead. The unit tests can download the raw files directly from github. The repo will be public as well so there won't be any need for authorization. Update `DeleteBinObjTest` to use `7z`
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Nov 4, 2022
* main: [Tests] Replace azurestorage with a github repo. (dotnet#7524) Bump to xamarin/Java.Interop/main@5318261 (dotnet#7502) [build] fix 8.0.100-alpha.1 version band (dotnet#7500) [monodroid] Disable loading of libLLVM at runtime (dotnet#7499) Bump to dotnet/installer@8c1708f 8.0.100-alpha.1.22526.2 (dotnet#7497)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Nov 4, 2022
* main: [Tests] Replace azurestorage with a github repo. (dotnet#7524)
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
https://xamjenkinsartifact.azureedge.net
site for some of the unit test data seems to have disappeared.So lets use a github repo to store this data instead. The unit tests can download the raw files directly from github. The repo will be public as well so there won't be any need for authorization.
The new repo can currently be found at https://github.com/dellis1972/xamarin-android-unittest-files.