[DevOps] Rename the yaml-tempaltes resources to match the MAUI repo. #7533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an attempt to unify the build for all the SDKs we need to rename all the resources to use the same names. This change follows the pattern used by tehe MAUI repo. Partial fix for xamarin/sdk-insertions#39
mandel-macaque
added
the
Area: xamarin-android Build
|
@mandel-macaque Looks like this failed https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6929520&view=results -- Some templates parameterized the yaml-templates resource name to deal with the fact that various repos used different names, those instances will also need to be updated (e.g. https://github.com/xamarin/xamarin-android/blob/main/build-tools/automation/azure-pipelines.yaml#L1454) |
pjcollins
reviewed
Nov 7, 2022
| @@ -11,7 +11,7 @@ pr: | |||
| # External sources, scripts, tests, and yaml template files. | |||
| resources: | |||
| repositories: | |||
| - repository: yaml | |||
| - repository: xamarin-templates | |||
There was a problem hiding this comment.
If we are working to standardize this name across repos, should we use the repo name yaml-templates everywhere instead of xamarin-templates? I wonder if the latter name might get confused with https://github.com/xamarin/xamarin-templates.
pjcollins
approved these changes
Nov 7, 2022
mandel-macaque
added a commit
to mandel-macaque/maui
that referenced
this pull request
Nov 7, 2022
This follow the changes in the other sdk repos: - macios: dotnet/macios#16618 - android: dotnet/android#7533 And it is a partial fix for xamarin/sdk-insertions#39
rmarinho
pushed a commit
to dotnet/maui
that referenced
this pull request
Nov 8, 2022
…1166) This follow the changes in the other sdk repos: - macios: dotnet/macios#16618 - android: dotnet/android#7533 And it is a partial fix for xamarin/sdk-insertions#39
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to unify the build for all the SDKs we need to rename all the resources to use the same names. This change follows the pattern used by tehe MAUI repo.
Partial fix for https://github.com/xamarin/sdk-insertions/issues/39