Missing androidx.window.[extensions|sidecar] warnings #9085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
approved these changes
Jul 8, 2024
Fixes dotnet#6809 We have an issues where if a library manifest contains the following element and the file dos NOT exist in `android-sdk\platforms\android-XX\optional` we get an XA4218 warning. ```xml <uses-library android:name="androidx.window.sidecar" android:required="false" /> ``` This is the warning. ``` Warning XA4218: Unable to find //manifest/application/uses-library at path: android-sdk\platforms\android-31\optional\androidx.window.sidecar.jar obj\Release\120\android\AndroidManifest.xml ``` So the work around this issue if the `required` attribute is NOT `true` we should ignore the warning. If the library is `required`` or the `required` attribute is NOT specified we should revert to to the current behavior. This warnings can come up if people use vendor specific .aar files. The libraries they are referring too will never exist in the `sdk` `optional` folder.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
added a commit
that referenced
this pull request
Jul 23, 2024
* main: (23 commits) Localized file check-in by OneLocBuild Task (#9129) [ci] Disable CodeQL on CI/PR pipelines (#9128) Refine 16k page alignment support (#9075) [build] fix `ConfigureLocalWorkload` target (#9124) Bump to NDK r27 (#9020) [ci] Use drop service for SDK insertion artifacts (#9116) Fix up all mapping paths (#9121) [ci] Fix maestro publishing for stable packages (#9118) Bump to dotnet/sdk@2f14fea98b 9.0.100-preview.7.24367.21 (#9108) Missing androidx.window.[extensions|sidecar] warnings (#9085) [ci] Use sign-artifacts template for macOS signing (#9091) [ci] Use DotNetCoreCLI to sign macOS files (#9102) [ci] Disable CodeQL on macOS, Linux, non-main jobs (#9111) [tests] re-enable `JavaAbstractMethodTest` (#9097) [Microsoft.Android.Sdk.ILLink] preserve types with `IJniNameProviderAttribute` (#9099) [Mono.Android] Data sharing and Close() overrides (#9103) [AndroidManifest] Add `Android.App.PropertyAttribute` (#9016) [Mono.Android] Add support for AndroidMessageHandler ClientCertificates (#8961) [Mono.Android] Bind and enumify API-35 (#9043) Bump to dotnet/java-interop@7a058c0e (#9066) ...
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6809
We have an issues where if a library manifest contains the following element and the file dos NOT exist in
android-sdk\platforms\android-XX\optionalwe get an XA4218 warning.This is the warning.
So the work around this issue if the
requiredattribute is NOTtruewe should ignore the warning. If the library isrequiredor therequiredattribute is NOT specified we should revert to to the current behavior.This warnings can come up if people use vendor specific .aar files. The libraries they are referring too will never exist in the
sdkoptionalfolder.