[Xamarin.Android.Build.Tasks] introduce LlvmIrTypeCache
#9251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/dotnet/android/blob/main/Documentation/guides/tracing.md#how-to-dotnet-trace-a-build Making a XAML or small C# change in a .NET MAUI project and running an incremental build, shows a reasonable amount of time spent in `<GenerateJavaStubs />` -- even with a device attached. If I attach `dotnet trace` to `dotnet build`, I can see time spent in: 117.08ms (2.20%) xamarin.android.build.tasks!Xamarin.Android.Tasks.LLVMIR.MemberInfoUtilities.GetNumberFormat(class System.Reflection.MemberInfo) 82.33ms (1.60%) xamarin.android.build.tasks!Xamarin.Android.Tasks.LLVMIR.MemberInfoUtilities.IsNativePointerToPreallocatedBuffer(class System.Reflection.MemberInfo,unsigned int64&) 29.30ms (0.56%) xamarin.android.build.tasks!Xamarin.Android.Tasks.LLVMIR.MemberInfoUtilities.UsesDataProvider(class System.Reflection.MemberInfo) 17.49ms (0.33%) xamarin.android.build.tasks!Xamarin.Android.Tasks.LLVMIR.MemberInfoUtilities.PointsToSymbol(class System.Reflection.MemberInfo,class System.String&) 15.03ms (0.29%) xamarin.android.build.tasks!Xamarin.Android.Tasks.LLVMIR.MemberInfoUtilities.IsNativePointer(class System.Reflection.MemberInfo) 3.59ms (0.07%) xamarin.android.build.tasks!Xamarin.Android.Tasks.LLVMIR.MemberInfoUtilities.IsInlineArray(class System.Reflection.Membe Where all of this time is spent in `MemberInfoUtilities` doing System.Reflection to lookup members such as: [NativeAssembler (NumberFormat = LLVMIR.LlvmIrVariableNumberFormat.Hexadecimal)] public uint mono_components_mask; Introduce `LlvmIrTypeCache` to cache `NativePointerAttribute` or `NativeAssemblerAttribute` values based on `MemberInfo`. This cache will live the lifetime of a `LlvmIrComposer` instance, so future builds will not persist the cache. With these changes in place, I see a modest improvement in an incremental build with a XAML change with an attached device (1 RID): Before: Task GenerateJavaStubs 1008ms After: Task GenerateJavaStubs 872ms So, this probably improves things by about 100ms or so.
grendello
approved these changes
Aug 27, 2024
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/dotnet/android/blob/main/Documentation/guides/tracing.md#how-to-dotnet-trace-a-build
Making a XAML or small C# change in a .NET MAUI project and running an incremental build, shows a reasonable amount of time spent in
<GenerateJavaStubs />-- even with a device attached.If I attach
dotnet tracetodotnet build, I can see time spent in:Where all of this time is spent in
MemberInfoUtilitiesdoing System.Reflection to lookup members such as:Introduce
LlvmIrTypeCacheto cacheNativePointerAttributeorNativeAssemblerAttributevalues based onMemberInfo. This cache will live the lifetime of aLlvmIrComposerinstance, so future builds will not persist the cache.With these changes in place, I see a modest improvement in an incremental build with a XAML change with an attached device (1 RID):
So, this probably improves things by about 100ms or so.