[native] Switch C++ standard to C++23 #9325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
changed the title
jonpryor
reviewed
Sep 25, 2024
| @@ -22,7 +22,7 @@ void | |||
| MonodroidRuntime::log_traces (JNIEnv *env, TraceKind kind, const char *first_line) noexcept | |||
| { | |||
| if (!tracing_init_done) { | |||
| std::lock_guard lock (tracing_init_lock); | |||
There was a problem hiding this comment.
My mistake, I missed it back then.
grendello
force-pushed
the
dev/grendel/c++23
branch
from
f236871 to
eb7ea0c
Compare
|
The MAUI integration tests appear to fail in other PRs too |
grendello
force-pushed
the
dev/grendel/c++23
branch
from
eb7ea0c to
3a20310
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Whenever `size_t` or `ssize_t` types are used and an integer literal is involved, use the `uz` or `z` literal suffix. This is to make the intent explicit as well as to avoid hidden type conversions. Despite being more verbose, this makes the code more type-safe.
grendello
force-pushed
the
dev/grendel/c++23
branch
from
3a20310 to
4696580
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever
size_torssize_ttypes are used and an integer literal isinvolved, use the
uzorzliteral suffix. This is to make theintent explicit as well as to avoid hidden type conversions. Despite
being more verbose, this makes the code more type-safe.