Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Mono.Android] remove Xamarin.Android.VSAndroidDesigner.IsSupported feature switch #9471

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jonathanpeppers
Copy link
Member

Context: https://developercommunity.visualstudio.com/t/XamarinAndroid-Designer---Replacement/10728132
Context: 363935b

As the Android designer is no longer supported in Visual Studio, we are removing the Xamarin.Android.VSAndroidDesigner.IsSupported feature switch and $(VSAndroidDesigner) MSBuild property.

This removes the codepath for Java types at runtime (on desktop) via TypeManager.TypeRegistrationFallback(). This also removes a Console.WriteLine() call when liblog and __android_log_print cannot be found.

… feature switch

Context: https://developercommunity.visualstudio.com/t/XamarinAndroid-Designer---Replacement/10728132
Context: 363935b

As the Android designer is no longer supported in Visual Studio, we
are removing the `Xamarin.Android.VSAndroidDesigner.IsSupported`
feature switch and `$(VSAndroidDesigner)` MSBuild property.

This removes the codepath for Java types at runtime (on desktop) via
`TypeManager.TypeRegistrationFallback()`. This also removes a
`Console.WriteLine()` call when `liblog` and `__android_log_print`
cannot be found.
@jonathanpeppers jonathanpeppers marked this pull request as ready for review October 30, 2024 20:52
Copy link
Contributor

@dellis1972 dellis1972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@jonpryor jonpryor merged commit 6ac69be into main Nov 8, 2024
58 checks passed
@jonpryor jonpryor deleted the Xamarin.Android.VSAndroidDesigner.IsSupported branch November 8, 2024 19:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants