Remove the AndroidUseAapt2 MSBuild property #9506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
requested review from
jonathanpeppers and
jonpryor
as code owners
jonathanpeppers
approved these changes
Nov 18, 2024
jonathanpeppers
approved these changes
Nov 18, 2024
Alphabetical!
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AndroidUseAapt2MSbuild property. All of the code it was protecting is now the default and users are no longer able to useaapt. So this property is redundant.ResolveAndroidToolingtask to look for .cmd,.bat and .exe like we do other tools. While this is not needed at the moment, it is useful for unit tests since we cannot create a .cmd file and name it .exe and have it run. It also allows us the flexibility to write wrappers for the tool if needed.