Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding target that wraps building a pkgproj and then updating package index #4632

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

joperezr
Copy link
Member

cc: @safern @ericstj

Whenever there is a failure in harvesting validation due to a new revision of a package getting shipped in a different release, our current task instructs in the failure to run UpdatePackageIndex task on the failing project with a property set in order to fix the issue. @safern recently hit this (dotnet/runtime#1729) and saw the problem that in order for this instruction to work, the pkgproj has to be built first, and there could be the case where locally this hasn't happened yet, and there is no clear instruction saying that this is the problem. In order to fix this, @safern and I decided to add a Target that would wrap both the build of the package, and the Update of the package index such that the instructions on the error will still work in case the package isn't built yet.

@joperezr joperezr requested review from ericstj and safern January 15, 2020 00:04
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joperezr joperezr merged commit 0eed4ac into dotnet:master Jan 16, 2020
@joperezr joperezr deleted the AddNewHarvestingTarget branch January 16, 2020 00:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants