-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Replace health check publisher and scheduler with ResourceHealthCheckService and introduce ResourceReadyEvent. #5870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
added
the
area-app-model
Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
label
Sep 24, 2024
davidfowl
reviewed
Sep 24, 2024
davidfowl
reviewed
Sep 24, 2024
src/Aspire.Hosting/Health/ResourceNotificationHealthCheckPublisher.cs
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Open
3 tasks
mitchdenny
force-pushed
the
mitchdenny/resource-healthy-event
branch
from
September 25, 2024 05:49
6393f39
to
6a69d3a
Compare
3 tasks
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
mitchdenny
changed the title
ResourceHealthyEvent and suppressing health checks that have become healthy.
Replace health check publisher and scheduler with ResourceHealthCheckService and introduce ResourceReadyEvent.
Sep 29, 2024
davidfowl
reviewed
Sep 29, 2024
davidfowl
reviewed
Sep 29, 2024
davidfowl
reviewed
Sep 29, 2024
davidfowl
reviewed
Sep 29, 2024
davidfowl
reviewed
Sep 29, 2024
davidfowl
reviewed
Sep 29, 2024
davidfowl
reviewed
Sep 29, 2024
davidfowl
reviewed
Sep 30, 2024
davidfowl
reviewed
Sep 30, 2024
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
davidfowl
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up: Make ResourceHealthCheckService more testable using the time provider and add more logs.
…m/dotnet/aspire into mitchdenny/resource-healthy-event
This was referenced Sep 30, 2024
Closed
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the health check publisher and scheduler and combines it into a single
ResourceHealthCheckService
which runs in the background doing health checks on a per resource basis.Fixes #5602
Fixes #5638
Fixes #5871
Fixes #5943
Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow