-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor AspireStore APIs #7626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/Aspire.Hosting/Aspire.Hosting.csproj: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking nice now. Looks good. I just had a few minor comments to clean up.
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Can we get this into 9.1 build tonight..? |
/backport to release/9.1 |
Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13423606060 |
Merging. The dotnet.aspire check seems to be stuck, but it passed on the backport, so assuming it is fine. All other builds/tests passed. |
Description
Reacting to https://github.com/dotnet/aspire/pull/7374/files#r1950365868
IAspireStore
by moving one method to extensionsIAspireStore
from DIChecklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):