Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ApiExplorer): SubstitutedType have invalid property setter #1105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndreaCuneo
Copy link

fix(ApiExplorer): SubstitutedType have invalid property setter

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

The PropertySetter of the SubstitutedType properties have 0 parameters: they had the same signature of the Getter.

Fixes #1104

@AndreaCuneo
Copy link
Author

@dotnet-policy-service agree

The PropertySetter of the SubstitutedType have 0 parameters: they had the same signature of the Getter.

resolves: dotnet#1104
@AndreaCuneo AndreaCuneo force-pushed the bugfix/SubstituteTypeInvalidPropertySetter branch from 27ac7c3 to 41f8cda Compare August 28, 2024 09:52
@AndreaCuneo
Copy link
Author

@commonsensesoftware can you please take a look. is a 1 line change plus tests.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Properties generated by DefaultModelTypeBuilder have invalid setter: without parameter
1 participant