Preventing a scoped dependency from being disposed

[fiksen99]

We have a scenario where we:
Have an IMyClientFactory singleton, whose implementation is to output an IMyClient. It maintains an IMemoryCache of client's that is has used, and will return the cached IMyClient if present (the cache key is based around HttpContext.Items values) otherwise it will create a new IMyClient and return it. IMyClient is expensive to create. IMyClient implements IDisposable

The IMyClientFactory is registered as a singleton via services.AddSingleton<IMyClientFactory, MyClientFactory>()
The IMyClient is registered as a Scoped like so:

services.AddSingleton<IMyClient>(sp =>
            {
                var factory = sp.GetRequiredService<MyClientFactory>();
                return factory.GetClientAsync().Result;
            });

unfortunately, due to default scoping behaviour, myClient.Dispose() is called at the end of every request scope, this means that the cached client is now disposed and unusable.

We should provide a mechanism such the the dispose behaviour is not necessarily called at scope end time, perhaps a flag to the AddScoped/AddTransient methods such that dispose isn't automatically called.

Alternatively, we could provide a mechanism such that calling AddSingleton with a factory method will always call into the factory method?

[muratg]

We are closing this issue because no further action is planned for this issue.