-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
updating signalr js package readme #22129
Conversation
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
We need to update the patch config aspnetcore/eng/PatchConfig.props Line 65 in d4f43e7
Add |
@BrennanConroy we need to re-ship this package with the updated readme? |
Yes, we're trying to update the README on npm which needs a published package with the update. |
a72bea1
to
7e48ac4
Compare
??? |
Well, that's not good. 21 commits is much more than I expected. Did you perhaps rebase on release/3.1❔ Or is this just another GitHub UI oddity❔ |
7e48ac4
to
283cea6
Compare
Neither which is why this is super annoying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is super annoying.
Yes
Co-authored-by: Brennan <brecon@microsoft.com>
283cea6
to
218d4fd
Compare
Fixed |
Was the issue an incomplete rebase i.e. having conflicts when pushing❔ |
Having a different remote that was ~21 commits behind :/ |
Please ping when checks complete and you've confirmed the |
Npm package created and build passed 👍 |
per the doc issue reported here, this update makes it more up-front which client customers should use, when their only knowledge of SignalR Is from perusing NPM packages, or who find their way here via OG SignalR docs.
wasn't sure which branch to suggest as upstream - goal here is simply to update the npm readme for the pre-
@microsoft/signalr
era.