Skip to content

Disable cookie name encoding/decoding #23579

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Jul 1, 2020

#23578

This encoding allows for cookie prefixes to be spoofed so we've decided to remove it. Calling HttpResponse.Cookies.Append with an invalid cookie name will now throw an ArgumentException.

@Tratcher Tratcher added breaking-change This issue / pr will introduce a breaking change, when resolved / merged. area-servers labels Jul 1, 2020
@Tratcher Tratcher added this to the 5.0.0-preview8 milestone Jul 1, 2020
@Tratcher Tratcher requested a review from halter73 July 1, 2020 18:47
@Tratcher Tratcher requested a review from jkotalik as a code owner July 1, 2020 18:47
@Tratcher Tratcher self-assigned this Jul 1, 2020
@Tratcher Tratcher merged commit 8182bb1 into dotnet:master Jul 2, 2020
@Tratcher Tratcher deleted the tratcher/5_cookies branch July 2, 2020 23:21
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions breaking-change This issue / pr will introduce a breaking change, when resolved / merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants