Skip to content

[3.1] Remove cookie name decoding #24389

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2020
Merged

[3.1] Remove cookie name decoding #24389

merged 1 commit into from
Aug 13, 2020

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Jul 28, 2020 •
edited
Loading

This is a port of the 2.1 PR #24264 plus a minor infrastructure fix.

@Tratcher Tratcher added this to the 3.1.x milestone Jul 28, 2020
@Tratcher Tratcher requested review from blowdart and HaoK July 28, 2020 22:54
@Tratcher Tratcher self-assigned this Jul 28, 2020
@ghost ghost added the area-servers label Jul 28, 2020
@Pilchie Pilchie added the Servicing-consider Shiproom approval is required for the issue label Aug 11, 2020
@ghost
Copy link

ghost commented Aug 11, 2020

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

@leecow leecow added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Aug 11, 2020
@leecow leecow modified the milestones: 3.1.x, 3.1.8 Aug 11, 2020
@Tratcher Tratcher force-pushed the tratcher/release/3.1/cookiename branch from ea7c331 to 68d9647 Compare August 13, 2020 00:06
@Tratcher Tratcher marked this pull request as ready for review August 13, 2020 00:07
@Tratcher Tratcher requested a review from jkotalik as a code owner August 13, 2020 00:07
@Tratcher
Copy link
Member Author

@dougbu can this be merged, or do you want to wait for #24838 and #24375?

@dougbu
Copy link
Contributor

dougbu commented Aug 13, 2020

Nothing is blocking this one. Do you need me to merge it❔

@Tratcher
Copy link
Member Author

Yes please.

@Tratcher Tratcher mentioned this pull request Aug 13, 2020
Merged
@dougbu dougbu merged commit ad4f0a0 into release/3.1 Aug 13, 2020
@dougbu dougbu deleted the tratcher/release/3.1/cookiename branch August 13, 2020 17:10
@Tratcher Tratcher mentioned this pull request Aug 26, 2020
Closed
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@blowdart blowdart blowdart approved these changes

@HaoK HaoK HaoK approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees

@Tratcher Tratcher

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
3.1.8
Development

Successfully merging this pull request may close these issues.
7 participants
@Tratcher @dougbu @blowdart @HaoK @Pilchie @leecow @amcasey