Sync shared code from runtime #39453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Pranav, it looks like this should be reverted and excluded. These methods aren't intend to be static, they're just not fully implemented yet. |
|
The rule is suppressed for these types: https://github.com/dotnet/aspnetcore/blob/main/.editorconfig#L285, but I think the codefix might have been aggressive about updating this file. We should be able to merge this without any additional changes. |
pranavkm
approved these changes
Jan 12, 2022
ghost
added this to the 
amcasey
added
area-networking
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to sync shared code changes from runtime. Fixes #18943