Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Blazor] Finalize the integration between runtime and Blazor #49385

Merged
merged 19 commits into from
Jul 14, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Jul 13, 2023

Closes dotnet/runtime#87178

@maraf maraf added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Jul 13, 2023
@maraf maraf added this to the 8.0-preview7 milestone Jul 13, 2023
@maraf maraf requested a review from pavelsavara July 13, 2023 12:40
@maraf maraf self-assigned this Jul 13, 2023
@maraf
Copy link
Member Author

maraf commented Jul 13, 2023

@javiercn @MackinnonBuck The CI will fail until changes from runtime flow to aspnetcore, but I would appreciate your feedback sooner, ideally to make it to preview7.


// Allow overriding the URI from which the dotnet.*.js file is loaded
if (startOptions.loadBootResource) {
const resourceType: WebAssemblyBootResourceType = 'dotnetjs';
const customSrc = startOptions.loadBootResource(resourceType, dotnetJsResourceName, src, dotnetJsContentHash);
const customSrc = startOptions.loadBootResource(resourceType, 'dotnet.js', src, '');
Copy link
Member Author

@maraf maraf Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is possible a breaking change, because we don't have a hash of dotnet.js anymore, but I'm sure if there is a case where it was usable when providing only URL for script

@maraf maraf marked this pull request as ready for review July 14, 2023 11:58
@maraf maraf requested a review from a team as a code owner July 14, 2023 11:58
@maraf maraf merged commit 2c9198f into dotnet:main Jul 14, 2023
@maraf maraf deleted the BlazorImportDotnetJs branch July 14, 2023 16:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor shouldn't enable debugging when not debugging
3 participants