API-diff between .NET 6.0 and .NET 7.0 #7976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
approved these changes
Nov 18, 2022
pchaurasia14
approved these changes
Nov 18, 2022
adamsitnik
reviewed
Nov 18, 2022
release-notes/7.0/7.0.0/api-diff/Microsoft.NETCore.App/7.0.0_System.IO.md
Outdated
Show resolved
Hide resolved
release-notes/7.0/7.0.0/api-diff/Microsoft.NETCore.App/7.0.0_System.IO.md
Outdated
Show resolved
Hide resolved
|
System.Diagnostics.Activity, System.Diagnostics.Metrics, and System.ComponentModel LGTM. I assume it is intentional to list the nullability differences in the existing APIs too. Right? |
...tes/7.0/7.0.0/api-diff/Microsoft.AspNetCore.App/7.0.0_Microsoft.AspNetCore.Components.Web.md
Outdated
Show resolved
Hide resolved
...0/7.0.0/api-diff/Microsoft.AspNetCore.App/7.0.0_Microsoft.AspNetCore.Connections.Features.md
Outdated
Show resolved
Hide resolved
release-notes/7.0/7.0.0/api-diff/Microsoft.AspNetCore.App/7.0.0_Microsoft.AspNetCore.Http.md
Outdated
Show resolved
Hide resolved
release-notes/7.0/7.0.0/api-diff/Microsoft.AspNetCore.App/7.0.0_Microsoft.AspNetCore.Http.md
Outdated
Show resolved
Hide resolved
| + public static IResult Text(string content, string contentType = null, Encoding contentEncoding = null, int? statusCode = default(int?)); | ||
| + public static IResult UnprocessableEntity<TValue>(TValue error); | ||
| - public static IResult ValidationProblem(IDictionary<string, string[]> errors, string? detail = null, string? instance = null, int? statusCode = default(int?), string? title = null, string? type = null, IDictionary<string, object?>? extensions = null); | ||
| + public static IResult ValidationProblem(IDictionary<string, string[]> errors, string detail = null, string instance = null, int? statusCode = default(int?), string title = null, string type = null, IDictionary<string, object?>? extensions = null); |
There was a problem hiding this comment.
More wrong nullability... I'm going to stop commenting on nullability inaccuracies otherwise I might be here all week
| public interface IStatusCodeReExecuteFeature { | ||
| + Endpoint Endpoint { get; } | ||
| - string? OriginalQueryString { get; set; } | ||
| + string OriginalQueryString { get; set; } |
StephenMolloy
approved these changes
Nov 18, 2022
release-notes/7.0/7.0.0/api-diff/Microsoft.NETCore.App/7.0.0_System.Runtime.Serialization.md
Outdated
Show resolved
Hide resolved
...7.0/7.0.0/api-diff/Microsoft.NETCore.App/7.0.0_System.Runtime.Serialization.DataContracts.md
Show resolved
Hide resolved
...7.0/7.0.0/api-diff/Microsoft.NETCore.App/7.0.0_System.Runtime.Serialization.DataContracts.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Brennan <brecon@microsoft.com> Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> Co-authored-by: Steve Molloy <smolloy@microsoft.com>
...tes/7.0/7.0.0/api-diff/Microsoft.AspNetCore.App/7.0.0_Microsoft.AspNetCore.Components.Web.md
Show resolved
Hide resolved
…0_Microsoft.AspNetCore.Components.Web.md Co-authored-by: Brennan <brecon@microsoft.com>
pavelsavara
reviewed
Nov 19, 2022
.../7.0/7.0.0/api-diff/Microsoft.NETCore.App/7.0.0_System.Runtime.InteropServices.JavaScript.md
Outdated
Show resolved
Hide resolved
dreddy-work
reviewed
Nov 21, 2022
...e-notes/7.0/7.0.0/api-diff/Microsoft.WindowsDesktop.App/7.0.0_System.Windows.Forms.Design.md
Show resolved
Hide resolved
Closed
carlossanlop
commented
Jan 3, 2023
...e-notes/7.0/7.0.0/api-diff/Microsoft.WindowsDesktop.App/7.0.0_System.Windows.Forms.Design.md
Outdated
Show resolved
Hide resolved
Xcalibur53
approved these changes
Jan 5, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASP.NET - @dotnet/aspnet-api-review
WinForms - @merriemcgaw @RussKie
WPF - @singhashish-wpf and @pchaurasia14
Libraries - @jeffhandley @karelz @ericstj @stephentoub
Microsoft.VisualBasic: @jaredpar @cston @333fred
Microsoft.Win32: @dotnet/area-microsoft-win32
System.Buffers: @dotnet/area-system-buffers
System.CodeDom: @dotnet/area-system-codedom
System.Collections: @dotnet/area-system-collections
System.ComponentModel: @dotnet/area-system-componentmodel
System.ComponentModel.Composition: @dotnet/area-system-componentmodel-composition
System.Data: @ajcvickers @DavoudEshtehari @David-Engel @JRahnama
System.Diagnostics.Activity: @dotnet/area-system-diagnostics-activity
System.Diagnostics.CodeAnalysis: @AaronRobinsonMSFT
System.Diagnostics.EventLog: @dotnet/area-system-diagnostics-eventlog
System.Diagnostics.Metrics: @tommcdon @noahfalk
System.Diagnostics.PerformanceCounter: @dotnet/area-system-diagnostics-performancecounter
System.Diagnostics.Process: @dotnet/area-system-diagnostics-process
System.Formats.Tar: @dotnet/area-system-io
System.IO: @dotnet/area-system-io
System.IO.Compression: @dotnet/area-system-io-compression
System.Linq: @dotnet/area-system-linq
System.Net: @dotnet/ncl
System.Numerics: @dotnet/area-system-numerics
System.Reflection: @dotnet/area-system-reflection
System.Reflection.Emit: @dotnet/area-system-reflection-emit
System.Reflection.Metadata: @dotnet/area-system-reflection-metadata
System.Resources: @dotnet/area-system-resources
System.Runtime.CompilerServices: @dotnet/area-system-runtime-compilerservices
System.Runtime.InteropServices: @dotnet/interop-contrib @lewing @pavelsavara
System.Runtime.Intrinsics: @dotnet/area-system-runtime-intrinsics
System.Runtime.Serialization: @HongGit @StephenMolloy
System.Runtime.Versioning: @buyaa-n
System.Runtime: @dotnet/area-system-runtime
System.Security: @dotnet/area-system-security
System.Text: @dotnet/area-system-text-encoding
System.Text.Json: @dotnet/area-system-text-json
System.Text.RegularExpressions: @dotnet/area-system-text-regularexpressions
System.Threading: @mangod9 @kouvel
System.Timers: @dotnet/area-system-componentmodel
System.Transactions: @HongGit @roji
System.Xml: @dotnet/area-system-xml
System.Web: @Rick-Anderson
System: @dotnet/area-system-runtime