Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add link to new workload set documentation #9483

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Add link to new workload set documentation #9483

merged 5 commits into from
Oct 23, 2024

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Aug 24, 2024

The markdownlint errors were already in this text before this PR.

@tdykstra tdykstra requested a review from baronfel August 24, 2024 21:25
Manifest Version: 8.0.2/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.aspire\8.0.2\WorkloadManifest.json
Install Type: Msi
Installation Source: SDK 8.0.400
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a valid result for .NET 9 preview 7?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the aspire workload was last installed when using 8.0.400-band SDKs, then yes - the next time a workload update happened (via dotnet workload install or dotnet workload update) I'd expect this to change to align with the in-use SDK's feature band.

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
@tdykstra tdykstra requested review from mairaw, leecow and rbhanda and removed request for leecow, mairaw and rbhanda October 22, 2024 22:08
@tdykstra
Copy link
Contributor Author

@rbhanda @leecow @baronfel
I fixed the preexisting Markdownlint errors, so this is ready to be merged now.

Copy link
Member

@leecow leecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tdykstra tdykstra merged commit 089221d into main Oct 23, 2024
5 checks passed
@tdykstra tdykstra deleted the tdykstra-patch-1 branch October 23, 2024 02:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants