This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add IL tests for cases where Span is not allowed #15746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have finished writing a similar (smaller) set of tests for #15745 literally 10 minutes ago... |
jkotas
reviewed
Jan 5, 2018
| @@ -0,0 +1,165 @@ | |||
| using System; | |||
|
Not sure whether it is worth keeping both sets from both my and this PR ... there seems to be quite a bit of overlap. LGTM otherwise. |
|
Maybe I can merge them |
ahsonkhan
reviewed
Jan 5, 2018
| @@ -0,0 +1,33 @@ | |||
| using System; | |||
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/coreclr/issues/8516