Skip to content

Containerized lifecycle/consolidated updates #19798

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 47 commits into from
Aug 6, 2020
Merged

Containerized lifecycle/consolidated updates #19798

merged 47 commits into from
Aug 6, 2020

Conversation

sughosneo
Copy link
Contributor

Summary

Merged all the pending PRs related to containerized-lifecycle in one PR and few minor fixes.

    • Broken link docker entry point link fix.
    • Removed dotnet core 2.2 reference link.

mvelosop and others added 22 commits April 15, 2020 17:57
@mvelosop
Add cover page
b3d6542
@mvelosop
Update images to VS 2019
d91417b
@mvelosop
General update of the VS Code-related docker workflow
22cc69a
@mvelosop
Update and fix extension case
acd9d32
@mvelosop
Update process and images
89edb1d
@mvelosop
Update aks creation parameters for sample/dev app
c68ef53
@mvelosop
General update of the article
6470fea
@mvelosop
Delete moved image
7eecf51
@mvelosop
Fix markdownlint error - Image alt text
7b61b17
@mvelosop
Update to restart pipeline b/c of error 500
8069249
@mvelosop
Including changes from PR dotnet#17865 and dotnet#17879
0e6284a
@mvelosop
containerized-lifecycle-3.1/3.1-index
d375bb2
@sughosneo
MIssing hypen fixes on the cover page.
bffc794
@sughosneo
Merge branch 'pr17863' into containerized-lifecycle/consolidated-updates
6ee3c9d
@sughosneo
Merge branch 'pr17957' into containerized-lifecycle/consolidated-updates
9148e28
@sughosneo
Merge branch 'pr17991' into containerized-lifecycle/consolidated-updates
48145a5
@sughosneo
Merge branch 'pr18004' into containerized-lifecycle/consolidated-updates
dd66114
@sughosneo
Merging all existing prs
8048cf8
@sughosneo
Merge branch 'pr18411' into containerized-lifecycle/consolidated-updates
636b992
@sughosneo
Consolidated updates on containerized-lifecycle e-book files.
eee8aa3
@sughosneo
Fixed broken link of container entry point.
2284b98
@sughosneo
Removed net core 2.2 reference
5efd224
@sughosneo sughosneo requested a review from nishanil as a code owner August 3, 2020 05:52
@dotnet-bot dotnet-bot added this to the August 2020 milestone Aug 3, 2020
sughosneo and others added 16 commits August 5, 2020 18:26
@sughosneo @nishanil
Update docs/architecture/containerized-lifecycle/Microsoft-platform-t…
55d71a1 
…ools-containerized-apps/index.md


Accepted suggestion.

Co-authored-by: Nish Anil <nish@microsoft.com>
@sughosneo @nishanil
Update docs/architecture/containerized-lifecycle/design-develop-conta…
bf4eac8 
…inerized-apps/visual-studio-tools-for-docker.md


Accepted suggestion.

Co-authored-by: Nish Anil <nish@microsoft.com>
@sughosneo @nishanil
Update docs/architecture/containerized-lifecycle/design-develop-conta…
189209c 
…inerized-apps/build-aspnet-core-applications-linux-containers-aks-kubernetes.md


Accepted suggestion.

Co-authored-by: Nish Anil <nish@microsoft.com>
@sughosneo
Included reviewer and participant name.
bd998a5
@sughosneo
Updated ms.date in all pages.
a685ddb
@sughosneo
Updated Azure CLI installation section for AKS
a4812ba
@sughosneo
Changed conversation context to second person.
fa06415
@sughosneo
Removed Preview information
f392a56
@sughosneo
Missing hypen related fixes.
fb1ad91
@sughosneo
Removed Trailing Spaces
0010b53
@sughosneo
Removed en-us from the link.
31b45d8
@sughosneo
Fixed broken link and rephrased sentence.
fa551ca
@sughosneo
Fixed Docker Desktop broken link.
1cc8c04
@sughosneo
Fixed broken link.
2d3ed32
@sughosneo
Rephrased AKS interaction segment.
05c4ce4
@sughosneo
Rephrased sentence
f08b8d1
nishanil
nishanil reviewed Aug 6, 2020
View reviewed changes
Copy link
Member

@nishanil nishanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more changes.

nishanil and others added 4 commits August 6, 2020 15:48
@nishanil
Update docs/architecture/containerized-lifecycle/design-develop-conta…
bfa1ce0 
…inerized-apps/build-aspnet-core-applications-linux-containers-aks-kubernetes.md
@nishanil
Update docs/architecture/containerized-lifecycle/design-develop-conta…
4b5dbb3 
…inerized-apps/deploy-azure-kubernetes-service.md
@sughosneo
Included review comments.
a782a8a
@sughosneo
Updated table.
2521c7e
nishanil
nishanil approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@nishanil nishanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nishanil nishanil merged commit b828d19 into dotnet:master Aug 6, 2020
@pkulikov
Copy link
Contributor

pkulikov commented Aug 6, 2020

@nishanil all the linked at the first message PRs may be closed now?

@nishanil
Copy link
Member

nishanil commented Aug 6, 2020

@pkulikov That's correct. However, I have asked @mvelosop to recheck once before I close them.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nishanil nishanil nishanil approved these changes

Assignees
No one assigned
Labels
containerized-lifecycle/subsvc dotnet-architecture/svc
Projects
None yet
Milestone
August 2020
Development

Successfully merging this pull request may close these issues.
6 participants
@sughosneo @pkulikov @nishanil @BillWagner @dotnet-bot @mvelosop