Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update NotifyCollectionChangedAction enum "Reset" description to not let it look like clearing collection #3253

Closed
marcelwgn opened this issue Sep 28, 2019 · 3 comments · Fixed by #3325
Labels
doc-bug Problem with the content; needs to be fixed easy Issue should be easy to implement, good for first-time contributors help wanted Good for community contributors to help [up-for-grabs] Pri3 Indicates issues/PRs that are low priority
Milestone

Comments

@marcelwgn
Copy link
Contributor

Currently, the description of the "Reset" value on the NotifyCollectionChangedAction enum page indicates that the collection was cleared. However some collection (for example Platform::Collections::Vector) use the reset event do indicate that the collection went through dramatic changes, such as ReplaceAll.

The UWP documentation for the enum describe the "Reset" value better:

The content of the collection changed dramatically.

In order for the value to be understand correctly, I think the documentations should line up regarding on what this value should or is used for.

See this issue over at WinUI for more context.

@dotnet-bot dotnet-bot added the untriaged New issue has not been triaged by the area owner label Sep 28, 2019
@mairaw mairaw added easy Issue should be easy to implement, good for first-time contributors help wanted Good for community contributors to help [up-for-grabs] and removed untriaged New issue has not been triaged by the area owner labels Oct 10, 2019
@mairaw mairaw added this to the Backlog milestone Oct 10, 2019
@mairaw
Copy link
Contributor

mairaw commented Oct 10, 2019

Thanks for your feedback @chingucoding. Would you like to submit a PR to fix this?
Here's some info about that: https://docs.microsoft.com/en-us/contribute/#quick-edits-to-existing-documents

@mairaw
Copy link
Contributor

mairaw commented Oct 10, 2019

I also noticed that this would match what's in the source code: https://source.dot.net/#System.ObjectModel/System/Collections/Specialized/NotifyCollectionChangedAction.cs,33

@GF-Huang
Copy link

So how can I access the OldItems when I got a Reset which casued by .Clear()?

@issues-automation issues-automation bot added the Pri3 Indicates issues/PRs that are low priority label Jun 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
doc-bug Problem with the content; needs to be fixed easy Issue should be easy to implement, good for first-time contributors help wanted Good for community contributors to help [up-for-grabs] Pri3 Indicates issues/PRs that are low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants