Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update IHttpClientLogger.cs and IHttpClientAsyncLogger.cs remarks #10653

Closed
wants to merge 2 commits into from

Conversation

danespinosa
Copy link

Summary

Describe your changes here.
Updates the documents for IHttpClientLogger.cs and IHttpClientAsyncLogger to provide a clearer guidance to the developer implementing this interface

Fixes #Issue_Number (if available)
This PR is paired up with fixing the actual code remarks too https://github.com/dotnet/runtime/pull/109618/files

update remarks to provide a clearer guidance to the developer implementing this interface
update remarks to provide a clearer guidance to the developer implementing this interface
@danespinosa danespinosa requested a review from a team as a code owner November 7, 2024 21:20
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 7, 2024
Copy link
Contributor

@danespinosa - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead.

Copy link

Learn Build status updates of commit 7aabada:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Http.Logging/IHttpClientAsyncLogger.xml ✅Succeeded View
xml/Microsoft.Extensions.Http.Logging/IHttpClientLogger.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant