Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Playwright E2E test cases #235

Merged
merged 11 commits into from
Mar 26, 2024
Merged

Conversation

SrushtiPasari94
Copy link
Contributor

Set up and Added playwright tests that check the functionality of:
Browsing for item
Adding item to cart
Removing item from cart

Copy link

@debs-obrien debs-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments to help improve the tests with link to docs for reference. Staging URL as discussed in DM would help for running tests on CI and seeing reports and traces

e2e/test-1.spec.ts Outdated Show resolved Hide resolved
e2e/test-1.spec.ts Outdated Show resolved Hide resolved
e2e/test-1.spec.ts Outdated Show resolved Hide resolved
e2e/test-1.spec.ts Outdated Show resolved Hide resolved
e2e/test-1.spec.ts Outdated Show resolved Hide resolved
e2e/test-1.spec.ts Outdated Show resolved Hide resolved
@SrushtiPasari94
Copy link
Contributor Author

@debs-obrien I have resolved all the comments. Please review the PR and approve if all good.
Thanks.

playwright.config.ts Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
e2e/AddItemTest.spec.ts Outdated Show resolved Hide resolved
e2e/BrowseItemTest.spec.ts Outdated Show resolved Hide resolved
e2e/#.setup.ts Outdated Show resolved Hide resolved
.github/workflows/playwright.yml Outdated Show resolved Hide resolved
.github/workflows/pr-validation.yml Outdated Show resolved Hide resolved
e2e/AddItemTest.spec.ts Outdated Show resolved Hide resolved
e2e/AddItemTest.spec.ts Outdated Show resolved Hide resolved
e2e/RemoveItemTest.spec.ts Outdated Show resolved Hide resolved
e2e/RemoveItemTest.spec.ts Outdated Show resolved Hide resolved
e2e/#.setup.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Srushti Pasari94 and others added 2 commits March 26, 2024 18:10
* fix: Playwright end-to-end tests

* nits

* test

* test

* test
@jamesmontemagno jamesmontemagno merged commit bd6f0d2 into main Mar 26, 2024
4 checks passed
@jamesmontemagno jamesmontemagno deleted the v-sruspasari/playwrightE2ETestCases branch March 26, 2024 16:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants