Migrations are too aggressive on RenameColumn

[yepeekai]

We made huge refactoring of our model for a new application. There is a lot of RenameColumn in the generated Migration and a lot of them don't make sense: Foreign keys have been removed and added to different tables and EF Core choose to rename columns even when the foreign key is for a different table.

If we drop EntityAId (pointing to EntityA) and add EntityBId (pointing to EntityB), it shouldn't be a rename but a drop and add.

I think it should be a DropColumn and a AddColumn instead of a RenameColumn for a foreign key that points to different entities.

[ajcvickers]

@yepeekai It's not possible to know for sure when something is a rename, so sometimes the heuristics will detect dropping and adding as a rename when it isn't. We discussed this in triage and didn't come up with anything specific we can do better, but if you have any suggestions from your specific case we would be interested in hearing them.

[yepeekai]

I think the example I gave would qualify as a suggestion on a case that should not be a rename... If it is a foreign key and it is for a different table then it is not a rename...

[ajcvickers]

@yepeekai Thanks--we will discuss.