Skip to content

Query: NotImplementedException thrown from QueryProviderTest.Non_generic_ExecuteQuery_does_not_throw_incorrect_pattern #15835

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
maumar opened this issue May 28, 2019 · 1 comment · Fixed by #23225
Assignees
Milestone

Comments

@maumar
Copy link
Contributor

maumar commented May 28, 2019

We used to swallow NIEs earlier because there were so many of them. We started letting them pass which exposed this issue.

@smitpatel
Copy link
Contributor

Difference here is that instead of query root expression, Constant of InternalDbSet gets in the expression tree. It should be easy to unwind.

@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 5, 2020
@smitpatel smitpatel removed this from the 6.0.0 milestone Nov 6, 2020
@ajcvickers ajcvickers added this to the 6.0.0 milestone Nov 6, 2020
smitpatel added a commit that referenced this issue Nov 6, 2020
@ghost ghost closed this as completed in #23225 Nov 6, 2020
ghost pushed a commit that referenced this issue Nov 6, 2020
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview1 Jan 27, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview1, 6.0.0 Nov 8, 2021
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants