Skip to content

Query: improve logic around Contains(byte array) #20155

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
maumar opened this issue Mar 4, 2020 · 2 comments · Fixed by #20489
Closed

Query: improve logic around Contains(byte array) #20155

maumar opened this issue Mar 4, 2020 · 2 comments · Fixed by #20489

Comments

@maumar
Copy link
Contributor

maumar commented Mar 4, 2020

Currently we special case how he handle contains on byte arrays. This should be cleaned up - AllAnyContainsRewritingExpressionVisitor should be able to run after nav expansion, but currently some cases of entity equality require it to run before it.

@smitpatel
Copy link
Contributor

Depends on #20164

@roji
Copy link
Member

roji commented Mar 22, 2020

Just to keep in mind... In PostgreSQL byte[] can be mapped in two ways: either as a binary type (called bytea, this is the default mapping), or as an array of bytes (just like you can have arrays of ints, arrays of strings). Being able to map to array of bytes is actually important to some users - sometimes used for enums with underlying byte type. Tell me if you need/want more details.

smitpatel added a commit that referenced this issue Apr 1, 2020
Part of #18923

Resolves #20155
Resolves #20369
We convert Queryable.Contains to Queryable.Any after navigation expansion has run so only true queraybles would have Queryable.Contains. Array properties would have Enumerable.Contains hence does not get rewritten.

Resolves #19433
smitpatel added a commit that referenced this issue Apr 1, 2020
Part of #18923

Resolves #20155
Resolves #20369
We convert Queryable.Contains to Queryable.Any after navigation expansion has run so only true queraybles would have Queryable.Contains. Array properties would have Enumerable.Contains hence does not get rewritten.

Resolves #19433
smitpatel added a commit that referenced this issue Apr 1, 2020
Part of #18923

Resolves #20155
Resolves #20369
We convert Queryable.Contains to Queryable.Any after navigation expansion has run so only true queraybles would have Queryable.Contains. Array properties would have Enumerable.Contains hence does not get rewritten.

Resolves #19433
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview4 Apr 20, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview4, 5.0.0 Nov 7, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants