Skip to content

Sqlite: add transaction savepoint API #20228

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Tracked by #22949
roji opened this issue Mar 9, 2020 · 7 comments · Fixed by #22869
Closed
Tracked by #22949

Sqlite: add transaction savepoint API #20228

roji opened this issue Mar 9, 2020 · 7 comments · Fixed by #22869

Comments

@roji
Copy link
Member

roji commented Mar 9, 2020

Sqlite supports the SQL Standard for savepoints: https://www.sqlite.org/lang_savepoint.html. SqlClient and Npgsql expose APIs for this their DbTransaction implementation, and dotnet/runtime#33397 tracks adding the relevant APIs in System.Data.

@bricelam
Copy link
Contributor

System.Data.SQLite leveraged savepoints to implement nested transactions at the ADO.NET layer. I like the proposed design better.

@ajcvickers
Copy link
Contributor

@roji @bricelam What is this blocked on? Should it be in 5.0 if it is blocked?

@bricelam
Copy link
Contributor

I think it was blocked on getting it into ADO.NET. I don't think it needs to be in 5.0.

@roji
Copy link
Member Author

roji commented Aug 25, 2020

@ajcvickers this is simply waiting for the new methods to appear in a new version of the SDK (I think preview8). I know it's technically an enhancement, but I think we should just do it. It's trivial to do, there's virtually no risk (new APIs) and it would make sense to implement the new 5.0 API in 5.0...

@ajcvickers ajcvickers removed this from the 5.0.0 milestone Aug 25, 2020
@ajcvickers
Copy link
Contributor

If it can go in this week, okay. Otherwise we'll discuss on Friday.

@smitpatel
Copy link
Contributor

@roji - Can you verify milestone/labels?

@roji
Copy link
Member Author

roji commented Oct 12, 2020

Thanks for taking care of it @smitpatel

@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview1 Jan 27, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview1, 6.0.0 Nov 8, 2021
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment