Skip to content

Update SQL transient error numbers to include 10936 #20923

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
dandenton opened this issue May 11, 2020 · 1 comment · Fixed by #20970
Closed

Update SQL transient error numbers to include 10936 #20923

dandenton opened this issue May 11, 2020 · 1 comment · Fixed by #20970
Assignees
Labels
customer-reported good first issue This issue should be relatively straightforward to fix. type-enhancement
Milestone

Comments

@dandenton
Copy link

dandenton commented May 11, 2020

Recently we've received these transient errors from our Azure SQL Server.

Microsoft.Data.SqlClient.SqlException (0x80131904): Resource ID : 1. The request limit for the elastic pool is 100 and has been reached. See 'http://go.microsoft.com/fwlink/?LinkId=267637' for assistance.

Error Number:10936,State:1,Class:20

Error 10936 isn't included in https://github.com/dotnet/efcore/blob/bde2b140d6f4cf94d6d1285d402941e20193ec60/src/EFCore.SqlServer/Storage/Internal/SqlServerTransientExceptionDetector.cs so the default SQL retry strategy isn't retrying.

I can't find much information about it but it's very similar to error 10928 - Resource ID: %d. The %s limit for the database is %d and has been reached. I would guess it just needs to be added to the list of transient errors.

As a workaround we've added it manually via the errorNumbersToAdd parameter in the constructor of SqlServerRetryingExecutionStrategy.

@dandenton
Copy link
Author

I also entered an issue to update the docs for this error - https://github.com/MicrosoftDocs/azure-docs/issues/54599

@ajcvickers ajcvickers added this to the 5.0.0 milestone May 15, 2020
@ajcvickers ajcvickers added the good first issue This issue should be relatively straightforward to fix. label May 15, 2020
@ajcvickers ajcvickers assigned smitpatel and unassigned bry-guy May 15, 2020
smitpatel added a commit that referenced this issue May 15, 2020
@AndriySvyryd AndriySvyryd removed their assignment May 15, 2020
smitpatel added a commit that referenced this issue May 15, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview6 Jun 1, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview6, 5.0.0 Nov 7, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
customer-reported good first issue This issue should be relatively straightforward to fix. type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants