Skip to content

Perf regression in existing data variations #22215

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
ajcvickers opened this issue Aug 25, 2020 · 4 comments · Fixed by #22261
Closed

Perf regression in existing data variations #22215

ajcvickers opened this issue Aug 25, 2020 · 4 comments · Fixed by #22261
Assignees
@smitpatel
Labels
area-change-tracking area-perf type-bug
Milestone
5.0.0

Comments

@ajcvickers
Copy link
Contributor

Likely due to local detect changes for cascade delete

image
@ajcvickers ajcvickers added this to the 5.0.0 milestone Aug 25, 2020
@ajcvickers ajcvickers self-assigned this Aug 25, 2020
@ajcvickers
Copy link
Contributor Author

@dotnet/efteam Made this poachable.

@smitpatel
Copy link
Contributor

Do we know commit which caused this?

@ajcvickers
Copy link
Contributor Author

We think it's adding the call to local DetectChanges here: #22079

@smitpatel smitpatel assigned smitpatel and unassigned ajcvickers Aug 27, 2020
@smitpatel
Copy link
Contributor

Found the root cause. PR coming in.

smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache change detector in state manager CascadeDelete
768d411 
Resolves #22215
@smitpatel smitpatel mentioned this issue Aug 27, 2020
Merged
@smitpatel smitpatel modified the milestones: 5.0.0, 5.0.0-rc1 Aug 27, 2020
smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache change detector in state manager CascadeDelete (#22261)
a57d2e5 
Resolves #22215
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@smitpatel smitpatel

Labels
area-change-tracking area-perf type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Caching is important 🐌 dotnet/efcore
2 participants
@ajcvickers @smitpatel