Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make IScaffoldingModelFactory public #23049

Closed
bricelam opened this issue Oct 19, 2020 · 3 comments · Fixed by #25094
Closed

Make IScaffoldingModelFactory public #23049

bricelam opened this issue Oct 19, 2020 · 3 comments · Fixed by #25094
Assignees
@bricelam
Labels
area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. poachable type-enhancement
Milestone
6.0.0

Comments

@bricelam
Copy link
Contributor

Seems like a useful service to both consume and override
@bricelam bricelam self-assigned this Oct 19, 2020
@roji
Copy link
Member

roji commented Oct 19, 2020

I want CSharpModelGenerator 😉

@bricelam
Copy link
Contributor Author

Templates might cause us to rethink that one.

@roji
Copy link
Member

roji commented Oct 19, 2020

😭

@ajcvickers ajcvickers added this to the Backlog milestone Oct 23, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 4, 2020
@bricelam bricelam added poachable good first issue This issue should be relatively straightforward to fix. labels May 7, 2021
bricelam added a commit to bricelam/efcore that referenced this issue Jun 14, 2021
@bricelam
Make IScaffoldingModelFactory public
993d0f1 
Fixes dotnet#23049
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 14, 2021
@bricelam bricelam mentioned this issue Jun 14, 2021
Merged
@ghost ghost closed this as completed in #25094 Jun 15, 2021
ghost pushed a commit that referenced this issue Jun 15, 2021
@bricelam
Make IScaffoldingModelFactory public (#25094)
954da6f 
Fixes #23049
@AndriySvyryd AndriySvyryd modified the milestones: 6.0.0, 6.0.0-preview6 Jul 2, 2021
@ajcvickers ajcvickers mentioned this issue Jul 29, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview6, 6.0.0 Nov 8, 2021
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@bricelam bricelam

Labels
area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. poachable type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Make IScaffoldingModelFactory public bricelam/efcore
4 participants
@bricelam @ajcvickers @roji @AndriySvyryd