Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Consider changing function mapping HasTranslation args from IReadOnlyCollection to IReadOnlyList #23565

Closed
maumar opened this issue Dec 3, 2020 · 0 comments · Fixed by #23712
Closed

Consider changing function mapping HasTranslation args from IReadOnlyCollection to IReadOnlyList #23565

maumar opened this issue Dec 3, 2020 · 0 comments · Fixed by #23712
Assignees
@maumar
Labels
area-query breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
6.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Dec 3, 2020

collection doesn't have indexer so its awkward to access arguments when constructing the tree
@ajcvickers ajcvickers added this to the 6.0.0 milestone Dec 4, 2020
maumar added a commit that referenced this issue Dec 17, 2020
@maumar
Fix to #23565 - Consider changing function mapping HasTranslation arg…
13b7fde 
…s from IReadOnlyCollection to IReadOnlyList

Makes it easier to access the args via indexer rather than doing link over it, e.g. args[2], rather than args.Skip(2).First()
@maumar maumar mentioned this issue Dec 17, 2020
Merged
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 17, 2020
maumar added a commit that referenced this issue Dec 18, 2020
@maumar
Fix to #23565 - Consider changing function mapping HasTranslation arg…
a333c04 
…s from IReadOnlyCollection to IReadOnlyList

Makes it easier to access the args via indexer rather than doing link over it, e.g. args[2], rather than args.Skip(2).First()
maumar added a commit that referenced this issue Dec 19, 2020
@maumar
Fix to #23565 - Consider changing function mapping HasTranslation arg…
6ef7c98 
…s from IReadOnlyCollection to IReadOnlyList

Makes it easier to access the args via indexer rather than doing link over it, e.g. args[2], rather than args.Skip(2).First()
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview1 Jan 27, 2021
@ajcvickers ajcvickers mentioned this issue Oct 17, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview1, 6.0.0 Nov 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@maumar maumar

Labels
area-query breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
6.0.0
2 participants
@ajcvickers @maumar