-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Utility of DataReaderDisposing logging/interception #24295
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
Comments
You can only read out parameter values after reader is closed but before it is disposed. |
Backlogging to add Close interception. |
23 tasks
Closing this in favor of #23535, since the same event covers both cases. |
ajcvickers
added a commit
that referenced
this issue
Jun 21, 2022
ajcvickers
added a commit
that referenced
this issue
Jun 23, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
RelationalDataReader has a logging/interception hook for disposing - but not for closing the reader (which happens just before). there's very little difference between a closed and disposed reader - both states are almost the same since the reader cannot be reused (unlike connection for example). Also, any I/O would very likely occur during Close, which is where we don't log the elapsed time etc.
Do we know if/how users are using this? Should we make DataReaderDisposing include Close as well, so that users can skip that via interceptors, and so that its time is logged too?
/cc @ajcvickers
The text was updated successfully, but these errors were encountered: