Skip to content

RelationalConnection.Close calls async function #26790

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
cincuranet opened this issue Nov 22, 2021 · 2 comments · Fixed by #26942 or #26943
Closed

RelationalConnection.Close calls async function #26790

cincuranet opened this issue Nov 22, 2021 · 2 comments · Fixed by #26942 or #26943
Assignees
@roji
Labels
area-global customer-reported Servicing-approved type-bug
Milestone
6.0.2

Comments

@cincuranet
Copy link
Contributor

The RelationalConnection.Close method calls CloseDbConnectionAsync in its codepath.

This obviously causes race between the closing code and what follows. Causing a nice havoc in FirebirdClient. :)
@roji roji self-assigned this Nov 22, 2021
@cincuranet cincuranet mentioned this issue Nov 22, 2021
Closed
roji added a commit to roji/efcore that referenced this issue Nov 22, 2021
@roji
Call sync connection close instead of async
af84702 
Fixes dotnet#26790
@roji roji mentioned this issue Nov 22, 2021
Closed
@roji
Copy link
Member

roji commented Nov 22, 2021

🤦

Thank @cincuranet - this was my fault, clearly a copy-paste error during the logging optimization work. Sorry for the trouble.

I've submitted #26793 for the 6.0 branch, with the proper description template for inclusion in a 6.0.x patch.

@cincuranet
Copy link
Contributor Author

cincuranet commented Nov 22, 2021 •
edited
Loading

No problem. I'm now just happy to find it. :) It took quite some time to spot the problem.

Should I close #26791? I see you closed it as I typed this.

@cincuranet cincuranet mentioned this issue Nov 22, 2021
Open
@roji roji mentioned this issue Nov 23, 2021
Closed
@roji roji linked a pull request Nov 23, 2021 that will close this issue
Call sync connection close instead of async #26793
Closed
roji added a commit to roji/efcore that referenced this issue Dec 8, 2021
@roji
Call sync connection close instead of async
b733390 
Also add missing ConfigureAwait(false) and StringComparison.Ordinal,
because of a configuration mismatch between FxCop and the built-in
diagnostics analyzers.

Fixes dotnet#26790
@roji roji mentioned this issue Dec 8, 2021
Merged
roji added a commit to roji/efcore that referenced this issue Dec 8, 2021
@roji
Call sync connection close instead of async
3a1cfca 
Also add missing ConfigureAwait(false) and StringComparison.Ordinal,
because of a configuration mismatch between FxCop and the built-in
diagnostics analyzers.

Fixes dotnet#26790
@roji roji mentioned this issue Dec 8, 2021
Merged
roji added a commit to roji/efcore that referenced this issue Dec 9, 2021
@roji
Call sync connection close instead of async
b3ec74d 
Also add missing ConfigureAwait(false) and StringComparison.Ordinal,
because of a configuration mismatch between FxCop and the built-in
diagnostics analyzers.

Fixes dotnet#26790
@ajcvickers ajcvickers added this to the 6.0.x milestone Dec 9, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.x, 6.0.2 Dec 14, 2021
roji added a commit to roji/efcore that referenced this issue Dec 16, 2021
@roji
Call sync connection close instead of async
557085e 
Also add missing ConfigureAwait(false) and StringComparison.Ordinal,
because of a configuration mismatch between FxCop and the built-in
diagnostics analyzers.

Fixes dotnet#26790
roji added a commit to roji/efcore that referenced this issue Dec 16, 2021
@roji
Call sync connection close instead of async
678a38c 
Also add missing ConfigureAwait(false) and StringComparison.Ordinal,
because of a configuration mismatch between FxCop and the built-in
diagnostics analyzers.

Fixes dotnet#26790
roji added a commit that referenced this issue Dec 16, 2021
@roji
Call sync connection close instead of async (#26942)
a778126 
Also add missing ConfigureAwait(false) and StringComparison.Ordinal,
because of a configuration mismatch between FxCop and the built-in
diagnostics analyzers.

Fixes #26790
@ajcvickers ajcvickers mentioned this issue Mar 1, 2022
Closed
@ajcvickers ajcvickers mentioned this issue Mar 9, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@roji roji

Labels
area-global customer-reported Servicing-approved type-bug
Projects
None yet
Milestone
6.0.2
3 participants
@ajcvickers @roji @cincuranet