Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change in behaviour of CSharpHelper.Identifier(string name) #29450

Closed
ErikEJ opened this issue Oct 28, 2022 · 5 comments · Fixed by #29821
Closed

Change in behaviour of CSharpHelper.Identifier(string name) #29450

ErikEJ opened this issue Oct 28, 2022 · 5 comments · Fixed by #29821
Labels
area-scaffolding customer-reported Servicing-approved type-bug
Milestone
7.0.3

Comments

@ErikEJ
Copy link
Contributor

ErikEJ commented Oct 28, 2022

Not sure if this can be considered a bug, but here you have it:

Given:

code.Identifier("MyStrange_ParameterName")

This returns:

 MyStrange_ParameterName

using EF Core 6

But

 MyStrangeParameterName

using EF Core 7
@ajcvickers ajcvickers added this to the 7.0.x milestone Nov 4, 2022
@ajcvickers
Copy link
Contributor

@ErikEJ Do you know what scenarios this breaks?

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Nov 5, 2022

Well- the behaviour change exposed a bug in my stored procedure mapping code. Could imagine it would effect some reverse engineering scenarios.

@ErikEJ ErikEJ mentioned this issue Nov 9, 2022
Closed
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Nov 9, 2022

Looks like the first issue is in now: ErikEJ/EFCorePowerTools#1577

@ErikEJ ErikEJ mentioned this issue Nov 15, 2022
Closed
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Nov 15, 2022

Related commit 41bd788#diff-d464e59a794ae7fd54b1770c49a469cbf1fe00850256d8660bd0fc833cc70a6e

@ajcvickers
Copy link
Contributor

@bricelam Looks like we should probably patch this.

AndriySvyryd added a commit that referenced this issue Dec 10, 2022
@AndriySvyryd
Allow underscores in identifiers again
33f63a6 
Fixes #29450
@AndriySvyryd AndriySvyryd removed their assignment Dec 10, 2022
@AndriySvyryd AndriySvyryd mentioned this issue Dec 10, 2022
Merged
AndriySvyryd added a commit that referenced this issue Dec 10, 2022
@AndriySvyryd
Allow underscores in identifiers again
48c7c0c 
Fixes #29450
@AndriySvyryd AndriySvyryd mentioned this issue Dec 10, 2022
Merged
AndriySvyryd added a commit that referenced this issue Dec 12, 2022
@AndriySvyryd
Allow underscores in identifiers again
4a2118f 
Fixes #29450
@AndriySvyryd AndriySvyryd reopened this Dec 12, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.x, 7.0.3 Dec 15, 2022
@ErikEJ ErikEJ mentioned this issue Dec 20, 2022
Closed
@AndriySvyryd AndriySvyryd mentioned this issue Jan 4, 2023
Closed
This was referenced Jan 13, 2023
Closed
Closed
@ajcvickers ajcvickers mentioned this issue Feb 6, 2023
Closed
@ajcvickers ajcvickers mentioned this issue Feb 16, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
area-scaffolding customer-reported Servicing-approved type-bug
Projects
None yet
Milestone
7.0.3
Development

Successfully merging a pull request may close this issue.

Allow underscores in identifiers again dotnet/efcore
4 participants
@bricelam @ajcvickers @ErikEJ @AndriySvyryd