Skip to content

StoreTypeNameBase isn't trimmed #30592

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
roji opened this issue Mar 29, 2023 · 1 comment · Fixed by #30593
Closed

StoreTypeNameBase isn't trimmed #30592

roji opened this issue Mar 29, 2023 · 1 comment · Fixed by #30593
Assignees
@roji
Labels
area-type-mapping customer-reported Servicing-rejected type-bug
Milestone
8.0.0

Comments

@roji
Copy link
Member

roji commented Mar 29, 2023 •
edited
Loading

If there a store type has facets (in parentheses), and there's whitespace separateing the base type and the parentheses, that whitespace gets included in the resulting mapping's StoreTypeNameBase. This can cause issues if that's later used in lookups etc.

See npgsql/efcore.pg#2690
@roji roji self-assigned this Mar 29, 2023
roji added a commit to roji/efcore that referenced this issue Mar 29, 2023
@roji
Trim the mapping store type base name
3b39357 
Fixes dotnet#30592
This was referenced Mar 29, 2023
Merged
Closed
@ajcvickers ajcvickers added this to the 8.0.0 milestone Mar 29, 2023
@ghost ghost closed this as completed in #30593 Mar 30, 2023
ghost pushed a commit that referenced this issue Mar 30, 2023
@roji
Trim the mapping store type base name (#30593)
bbf4d95 
Fixes #30592
@ajcvickers ajcvickers modified the milestones: 8.0.0, 8.0.0-preview4 Apr 20, 2023
@rwasef1830 rwasef1830 mentioned this issue May 22, 2023
Closed
@roji
Copy link
Member Author

roji commented May 22, 2023

Removing from milestone to consider servicing (requested in npgsql/efcore.pg#2757)

@roji roji removed this from the 8.0.0-preview4 milestone May 22, 2023
@roji roji reopened this May 22, 2023
@ajcvickers ajcvickers added this to the 7.0.x milestone May 26, 2023
ajcvickers pushed a commit that referenced this issue Sep 13, 2023
@roji @ajcvickers
Trim the mapping store type base name (#30593)
af5bbdb 
Fixes #30592
@ajcvickers ajcvickers mentioned this issue Sep 13, 2023
Closed
@ajcvickers ajcvickers modified the milestones: 7.0.x, 8.0.0-preview4 Oct 11, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0-preview4, 8.0.0 Nov 14, 2023
@roji roji marked this as a duplicate of npgsql/efcore.pg#2690 Apr 1, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@roji roji

Labels
area-type-mapping customer-reported Servicing-rejected type-bug
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Trim the mapping store type base name roji/efcore
2 participants
@ajcvickers @roji