Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Raw SQL literal with GO on a new line of that literal fails when executing migration #32826

Closed
ajcvickers opened this issue Jan 15, 2024 · 1 comment · Fixed by #34917
Closed

Raw SQL literal with GO on a new line of that literal fails when executing migration #32826

ajcvickers opened this issue Jan 15, 2024 · 1 comment · Fixed by #34917
Labels
area-migrations closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. preview-1 type-bug
Milestone
10.0.0

Comments

@ajcvickers
Copy link
Contributor

See #32788 (review)

Tests added as part of PR above.
@ajcvickers ajcvickers added this to the Backlog milestone Jan 18, 2024
@ChrisJollyAU
Copy link
Contributor

I'll take an attempt at this

ChrisJollyAU added a commit to ChrisJollyAU/efcore that referenced this issue Sep 29, 2024
@ChrisJollyAU
Handle GO within a sql statement better
929aa91 
fixes dotnet#32826
@ChrisJollyAU ChrisJollyAU mentioned this issue Sep 29, 2024
Closed
AndriySvyryd added a commit that referenced this issue Oct 10, 2024
@AndriySvyryd
Don't execute empty batches
73819e4 
Don't remove quoted 'GO' lines

Fixes #32826
Fixes #33337
@AndriySvyryd AndriySvyryd mentioned this issue Oct 10, 2024
Merged
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 10.0.0 Oct 11, 2024
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 11, 2024
AndriySvyryd added a commit that referenced this issue Oct 16, 2024
@AndriySvyryd
Don't remove quoted 'GO' lines
6b2465d 
Fixes #32826
@AndriySvyryd AndriySvyryd mentioned this issue Oct 16, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
area-migrations closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. preview-1 type-bug
Projects
None yet
Milestone
10.0.0
4 participants
@ajcvickers @maumar @AndriySvyryd @ChrisJollyAU