Skip to content

Set the ordering as the identifier when translating VALUES #33436

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
roji opened this issue Mar 30, 2024 · 3 comments · Fixed by #33439
Closed

Set the ordering as the identifier when translating VALUES #33436

roji opened this issue Mar 30, 2024 · 3 comments · Fixed by #33439

Comments

@roji
Copy link
Member

roji commented Mar 30, 2024

Our translation of inline collections to SQL ValuesExpression does not specify an identifier, making it impossible to use project in certain query contexts.

Flagged by @maumar in #33410 (comment)

@maumar
Copy link
Contributor

maumar commented Apr 6, 2024

@roji, should we patch this, given that #33410 is a regression and the fix is not too complicated?

@maumar maumar reopened this Apr 6, 2024
@roji
Copy link
Member Author

roji commented Apr 6, 2024

See #33438 (comment)

@roji
Copy link
Member Author

roji commented Apr 15, 2024

Decision: we won't backport this since the workaround is trivial (add AsEnumerable()), and this doesn't actually address the customer-reported issue (which is about Concat, whereas this fixed Union). If additional user reports come in, we can reconsider.

@roji roji closed this as completed Apr 15, 2024
@roji roji modified the milestones: 9.0.0-preview4, 9.0.0 Oct 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants