-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Create default implementation of IDatabaseModelFactory #3438
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
We should look at using EF when we do this |
Made some discoveries from an attempted implementation in EF. Need to have: Nice to have: |
As a workaround to #3943 you should be able to put these things in shadow state and then after you execute the query run some additional logic to copy the values out of the change tracker into the annotations. |
@natemcmaster is the materialization hook you mention in #3943 a need to have in the sense that you cannot resolve this issue (#3438) without it? I would like to understand if it can be worked around. |
Listing the limitations above was more about minimizing workarounds and driving useful features in EF. They can all be worked around. @divega #3943 can be a "nice to have" since we don't plan to support multiple rows => one entity (#3945).
@rowanmiller this was my original approach. Of course this means I have to use the change tracker ( see #2282 (comment)) |
@natemcmaster we agreed not to use EF for loading metadata, but is the more general scenario covered by this issue (providers just needing to provide SQL) done? |
This general scenario is not done. We still only have a Sql Server and SQLite implementation with no shared implementation. |
It is maybe possible to provide a base implementation of IMetadataReader so that provider-writers only need to give us SQL queries to make reveng work. Use
INFORMATION_SCHEMA
Related #1667
The text was updated successfully, but these errors were encountered: