Skip to content

Handle value generation when value conversion is being used #11479

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 30, 2018

Conversation

ajcvickers
Copy link
Contributor

Fixes #11010

Approach is:

  • Throw by default if a converter is associated with a property that will use value generation
  • However, a value generator to use can be specified:
    • On the property
    • On the type mapping
    • On a converter
  • A client-side generator is added to the Guid converters so that Guid key scenarios still work

@ajcvickers ajcvickers requested a review from AndriySvyryd March 29, 2018 22:33
@ajcvickers
Copy link
Contributor Author

/cc @divega FYI

@divega
Copy link
Contributor

divega commented Mar 30, 2018

@ajcvickers are there still further improvements (like the ones we discussed yesterday) that would make sense to track in an issue, or do you prefer to wait for feedback?

@ajcvickers
Copy link
Contributor Author

@divega Probably worth having an issue to check for other "safe" generators we could add, but would rather wait until after 2.1 before we add any more anyway, so we could just wait for feedback instead.

Fixes #11010

Approach is:
* Throw by default if a converter is associated with a property that will use value generation
* However, a value generator to use can be specified:
  * On the property
  * On the type mapping
  * On a converter
* A client-side generator is added to the Guid converters so that Guid key scenarios still work
@ajcvickers ajcvickers merged commit b7ffe45 into release/2.1 Mar 30, 2018
@smitpatel smitpatel deleted the SayGenWot0328 branch April 5, 2018 19:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants