Skip to content

Model level eager loading configuration #19355

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Conversation

smitpatel
Copy link
Contributor

@smitpatel smitpatel commented Dec 18, 2019

IsEagerLoaded API on NavigationBuilder to mark a navigation as eagar loaded
IgnoreEagerLoadedNavigations API on query to ignore model based config

Resolves #21540

maumar
maumar previously approved these changes Dec 18, 2019
@ajcvickers
Copy link
Contributor

Tests?

@ajcvickers
Copy link
Contributor

@smitpatel Remind me why this is marked as blocked?

@smitpatel
Copy link
Contributor Author

We needed to add API to mark a navigation Eager loaded so that we can test this API.

IsEagerLoaded API on NavigationBuilder to mark a navigation as eagar loaded
IgnoreEagerLoadedNavigations API on query to ignore model based config

Resolves #21540
@smitpatel smitpatel force-pushed the smit/ignoreeagerloaded branch from 2ded191 to 3b5bca0 Compare July 7, 2020 02:31
@smitpatel smitpatel requested review from AndriySvyryd and maumar July 7, 2020 02:31
@smitpatel smitpatel removed the blocked label Jul 7, 2020
@smitpatel smitpatel changed the title Query: Add IgnoreEagerLoadedNavigations API Model level eager loading configuration Jul 7, 2020
@smitpatel smitpatel merged commit da5ed2e into master Jul 7, 2020
@smitpatel smitpatel deleted the smit/ignoreeagerloaded branch July 7, 2020 04:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query: Model configuration for eager load (Include)
4 participants