Query: Improvements to Navigation Expansion #19377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/navexpansion
branch
2 times, most recently
from
5effe0e to
698ed42
Compare
smitpatel
commented
Dec 30, 2019
| @@ -1994,5 +1996,96 @@ public virtual Task Using_same_parameter_twice_in_query_generates_one_sql_parame | |||
| ss => ss.Set<Customer>().Where(c => i + c.CustomerID + i == c.CompanyName) | |||
| .Select(c => c.CustomerID)); | |||
| } | |||
|
|
|||
| //[ConditionalTheory] | |||
smitpatel
force-pushed
the
smit/navexpansion
branch
2 times, most recently
from
8cd81ee to
fcc4f78
Compare
smitpatel
requested review from
roji,
maumar,
AndriySvyryd,
ajcvickers and
bricelam
| @@ -3300,7 +3283,7 @@ public virtual void Select_Where_Subquery_Equality() | |||
| using var context = CreateContext(); | |||
| var orders | |||
| = (from o in context.Orders.OrderBy(o => o.OrderID).Take(1) | |||
| // ReSharper disable once UseMethodAny.0 | |||
| // ReSharper disable once UseMethodAny.0 | |||
There was a problem hiding this comment.
VS auto-format did it. I believe this is one point where these is conflict between settings in IDEs.
AndriySvyryd
approved these changes
Dec 30, 2019
- Skip/Take does not force applying pending selector and changing shape. - Throw translation failure message for Querayble methods which we don't translate (hence we don't process in navigation expansion). Earlier we threw query failed message. Now Navigation Expansion does not throw QueryFailed error message from any place. - Unwrap type conversion for validating member access during include expansion so that we don't generate include when derived type's member is accessed. Resolves #18140 Resolves #18374 Resolves #18672 Resolves #18734 Resolves #19138 Resolves #19207
smitpatel
force-pushed
the
smit/navexpansion
branch
from
fcc4f78 to
447f48e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18140
Resolves #18374
Resolves #18672
Resolves #18734
Resolves #19138
Resolves #19207