Skip to content

Query: Add support for queryable functions #20053

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

smitpatel
Copy link
Contributor

@smitpatel smitpatel commented Feb 25, 2020

Part of #20051

@smitpatel smitpatel force-pushed the smit/queryableFunctions branch from 68d183a to f7b521c Compare February 25, 2020 00:42
@smitpatel
Copy link
Contributor Author

Got it right this time.

@smitpatel
Copy link
Contributor Author

cc: @pmiddleton

/// Checks whether the given expression can be evaluated.
/// </summary>
/// <param name="expression"> The expression. </param>
/// <param name="model"> The model. </param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do cleanup when I submit query changes PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have ability to make changes on this PR anymore since the source is now based from a branch in the main repo.

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make the metadata changes that I had requested previously.

@pmiddleton
Copy link
Contributor

Oh heck if you wanted something screwed up with git you should have called me. I'm the master of that!

@smitpatel smitpatel force-pushed the smit/queryableFunctions branch from f7b521c to bc8e7b1 Compare February 25, 2020 02:36
@ajcvickers
Copy link
Contributor

@smitpatel Careful. First you move closer to the dark side with the dark theme. Then you start messing up git. Then you even claim to have fixed it "like a boss." If you're not careful the dark side will draw you in. And then you become a manager.

@pmiddleton
Copy link
Contributor

image

@AndriySvyryd AndriySvyryd linked an issue Feb 25, 2020 that may be closed by this pull request
10 tasks
@smitpatel smitpatel force-pushed the smit/queryableFunctions branch from bc8e7b1 to bc79c82 Compare February 25, 2020 19:04
@smitpatel smitpatel merged commit ffe29af into master Feb 25, 2020
@smitpatel smitpatel deleted the smit/queryableFunctions branch February 25, 2020 19:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants