Query: Rewrite Entity Equality during translation phase #20447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/LongWayToGo
branch
from
ba04dd0 to
904a105
Compare
maumar
reviewed
Mar 31, 2020
src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
Mar 31, 2020
src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
maumar
reviewed
Mar 31, 2020
src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
Mar 31, 2020
src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
maumar
reviewed
Mar 31, 2020
src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
maumar
reviewed
Mar 31, 2020
src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.ExpressionVisitors.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
Mar 31, 2020
src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.ExpressionVisitors.cs
Show resolved
Hide resolved
maumar
reviewed
Mar 31, 2020
maumar
reviewed
Mar 31, 2020
maumar
approved these changes
Mar 31, 2020
Resolves #15080 Implemented behavior: - If any part of composite key is null then key is null. - If comparing entity with null then check if "any" key value is null. - If comparing entity with non-null then check if "all" key values are non null. Resolves #20344 Resolves #19431 Resolves #13568 Resolves #13655 Since we already convert property access to nullable, if entity from client is null, make key value as null. Resolves #19676 Clr type mismatch between proxy type and entity type is ignored. Resolves #20164 Rewrites entity equality during translation Part of #18923
smitpatel
force-pushed
the
smit/LongWayToGo
branch
from
904a105 to
b7360ca
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15080
Implemented behavior:
Resolves #20344
Resolves #19431
Resolves #13568
Resolves #13655
Since we already convert property access to nullable, if entity from client is null, make key value as null.
Resolves #19676
Clr type mismatch between proxy type and entity type is ignored.
Resolves #20164
Rewrites entity equality during translation
Part of #18923