[SMALL] Add capability to verify order in ordered filtered include queries #21305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
force-pushed
the
ordered_assert_include
branch
from
048aed5 to
e201bad
Compare
smitpatel
reviewed
Jun 17, 2020
test/EFCore.Specification.Tests/TestUtilities/ExpectedFilteredInclude.cs
Outdated
Show resolved
Hide resolved
maumar
force-pushed
the
ordered_assert_include
branch
from
e201bad to
17fd8db
Compare
|
@smitpatel updated |
|
No test failed? 😮 |
smitpatel
reviewed
Jun 19, 2020
smitpatel
approved these changes
Jun 19, 2020
maumar
force-pushed
the
ordered_assert_include
branch
from
17fd8db to
2b81ea9
Compare
ExpectedFilteredInclude now can be marked to verify order - by default we don't do it.
maumar
force-pushed
the
ordered_assert_include
branch
from
2b81ea9 to
1a78b52
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpectedFilteredInclude now detects whether filter contains ordering. Based on that information we either perform default ordering or leave the exisiting order as is.