Skip to content

Use object syntax for aliased projections #21347

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2020
Merged

Use object syntax for aliased projections #21347

merged 1 commit into from
Jun 20, 2020

Conversation

AndriySvyryd
Copy link
Member

Fixes #20976

@AndriySvyryd AndriySvyryd requested a review from smitpatel June 20, 2020 03:58
smitpatel
smitpatel approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make Value projection more first class in SelectExpression? Like how client eval is.
Could help in throwing better error when there is clash with SqlFunction & keywords

@AndriySvyryd
Copy link
Member Author

@smitpatel Sure, why not?

@AndriySvyryd AndriySvyryd merged commit 2818db7 into master Jun 20, 2020
@AndriySvyryd AndriySvyryd deleted the Issue20976 branch June 20, 2020 05:46
@ajcvickers ajcvickers mentioned this pull request Jun 25, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CosmosDatabaseWrapper - NullReferenceException in SaveAsync
2 participants
@AndriySvyryd @smitpatel